3 ms·
That's not the case for all programmers though. When I re-wrote the device handling code in Docker, I wasn't reading code that I had written, I was reading code
by timthelion 10y ago
That's not the case for all programmers though. When I re-wrote the device handling code in Docker, I wasn't reading code that I had written, I was reading code that was broken and that others had written. The point though is, to realize that the code evolved. When I searched through git blames, I saw that various parts of the code that wrote to cgroups had been added by various people in no coordinated fashion. Does this mean that the individuals were bad programmers? Individually, their commits looked fine. Need to add access to /dev/tty? Add a line of code to the src/tty.go file that writes to cgroups. Sounds perfectly reasonable, right? But it is not reasonable, when you find that you have 12 different places in the code that write to cgroups, and you find that the cgroups code actually needs to be unified to support standard cgroups, lxc, and systemd implementations, and the naive "add a line to the end of that cgroups file in /proc" only works in one of those configurations...
So yes, the code was shit, but the coders weren't.
- deleted 10y ago[deleted]