2 ms·
At my last job, the EE manager wanted to improve the quality of firmware, so one of the things he did was to ask for a software guy to show them how we did code
by HeyLaughingBoy 10y ago
At my last job, the EE manager wanted to improve the quality of firmware, so one of the things he did was to ask for a software guy to show them how we did code reviews.
As an EE working in software, I volunteered. One of the comments I made was that the many magic numbers in the code should be replaced by definitions that explained what they meant.
I got back code for re-review that contained the line:
#define ZERO 0
To this day I'm not sure if the author didn't understand or was just irritated at having me review his code. Probably both, come to think of it.