4 ms·
> I'm a junior SE at a startup; most of the time, my code requires quite some changes during the code review process. It really frustrates me and make me feel l
by dozzie 10y ago
> I'm a junior SE at a startup; most of the time, my code requires quite some changes during the code review process. It really frustrates me and make me feel like a fraud.
You're junior. You still learn. Your code is not expected to be good
until you get more training, and then you'll no longer be junior.
> From your experiences, how can I make sure that my code is solid enough that it does not require too many changes when reviewed by a Senior Engineer.
This is something you should be asking your reviewers. We don't know what you
are lacking, as we haven't seen your code.
- spoonie 10y agoYup! You could also try asking your reviewers to write out some coding guidelines. You can refer to these as a checklist before putting your code up for review. Or if you are really adventurous, start making this document yourself as you get feedback. The guide can includes things like coding style as well as mistakes to avoid "prefer do loops over while loops", "always check for nulls after $API_CALL". (As a bonus here, you will make mistakes in your doc and you'll get additional feedback: more learning opportunities.)