3 ms·
I rather actually see a real comment if there is no time to create a unit test. Why does changing ZQ_PEDERSEN to ZQ_WILLIAMSON fix the bug? Having meaningful
by edsouza 10y ago
I rather actually see a real comment if there is no time to create a unit test.
Why does changing ZQ_PEDERSEN to ZQ_WILLIAMSON fix the bug?
Having meaningful named constants would make much more sense.
Edit: On full view of the code, the bug could be avoid if they broke out the if <demoninationX> blocks into their own function, and to prevent "typo" errors, it would be good to have a local variable named current_demoniation = demoniationX, and then reference that local variable instead of referencing the constant everytime.
- Rangi42 10y agoApparently those are names for 50 and 100 BTC. From this presentation[1] or the source code[2]: 1 Lovelace = 1 Bitcoin 1 Goldwasser = 10 Bitcoin 1 Rackoff = 25 Bitcoin 1 Pedersen = 50 Bitcoin 1 Williamson = 100 Bitcoin But yes, those are meaningless names in themselves. Metric prefixes like "hectobitcoin" would be better. [1]: https://sar.informatik.hu-berlin.de/teaching/2013-w/2013-w%20Electronic%20Identity/slides/Anonymit%C3%A4t_in_Bitcoin_.pdf https://sar.informatik.hu-berlin.de/teaching/2013-w/2013-w%2... [2]: https://github.com/Zerocoin/libzerocoin/blob/master/Coin.h#L19-L27 https://github.com/Zerocoin/libzerocoin/blob/master/Coin.h#L...