3 ms·
There's nothing wrong with using assignment in if conditions. For example, `if let Some(thing) = computation_that_may_fail { ... }`.
by nilved 10y ago
There's nothing wrong with using assignment in if conditions. For example, `if let Some(thing) = computation_that_may_fail { ... }`.
- kazinator 10y agoThe operator there is let. The = is just a punctuator which indicates the initial value expression for the let. Litmus test: if this was rendered into S-expressions, the let would stay, but the = would disappear.
- nilved 10y agoNo, that's just because the example I used was Rust. In Ruby it would be `if user = User.find(..)` and the same goes for Go and plenty of other languages.
- kazinator 10y agoIf user is being freshly bound, that isn't an assignment but an initialization. If the construct is not allowed when user is already in scope, it reflects the designer's view that an assignment in a conditional isn't a good thing. If the construct is allowed when user exists already, with no diagnostic, then it carries the pitfalls that this thread is about.