4 ms·
Red flag - Misuse of css classes. <span class="star">*</span> I'd also ask if that markup was necessary. Is it to represent a bullet? If so, that's already
by manarth 10y ago
Red flag - Misuse of css classes.
<span class="star">*</span>
I'd also ask if that markup was necessary. Is it to represent a bullet? If so, that's already implied in the markup by the use of <li>, so a more semantic implementation would be to skip the markup completely, and either style it visually with list-style-image, or inject the star with the css pseudo-element ::before.
I'd also look at <h2 class="big">, and ask whether the class is needed, and the visual separators <p class="sign">@@@@@@@@@@@@@@@@@@@@@@@@@</p>. To a screen-reader user this would read "at at at at at at at at at at at at at at" etc.
These certainly wouldn't be deal-breakers for a hiring decision, but it would have me leaning towards a junior position for a candidate, and setting a goal of developing knowledge of semantic markup and accessibility.