4 ms·
Lots of thoughts around the code review issue (the jerk generated 'hundreds of comment'). I have a rule: the only comments I make are about improving the corre
by JoeAltmaier 10y ago
Lots of thoughts around the code review issue (the jerk generated 'hundreds of comment').
I have a rule: the only comments I make are about improving the correctness of the code. Nothing about technique or approach or format or cleverer ways of doing anything. Just directly actionable constructive comments.
- hinkley 10y agoI try to limit myself to being no more than 50% of the comments on a review. I know what that probably sounds like, but with experience, and especially if you study ergonomics like I do, you learn that certain patterns of code that look OK are actually accidents waiting to happen. This bizarre pattern you're using has caused 3 regressions already, and we are not interested in there being a 4th. To keep it to a dull roar, I do a number of things. Be consistent, prioritize, shop my concerns, and never go first. By consistently bringing up your top concerns eventually they'll disappear from the code reviews, or others will start making the comments before you can. As things improve you can start bringing up lesser, or deeper issues. If things don't improve you start asking your peers for help communicating the importance of the issue. By going last you let other people contribute, demonstrate consensus, cover issues so you don't have to be the messenger, and you know roughly how many comments the code is going to get.
- JoeAltmaier 10y agoWonderful technique! Its essentially 'mentoring the crowd' by constructive participation and modeling good social behavior. I have used a technique learned early on when I was a young jerk. Instead of arguing with folks in a group, I would sit one-on-one and discuss an issue (e.g. how are we going to structure the new project). I would start with a savvy experienced team member (ok John McGinty was his name) and get a consensus between us. Then I'd go to the next team member, and say "John thinks we should do this:" and say what we had come up with. Not "I think" which is confrontational; "John thinks ...". Now they've got to put their thoughts up against his, which most folks can do without getting emotionally invested. Anyway, iterate until the team was on the same page. End result: I get my way. Or I get convinced there's a better way. Either way, I win and the team wins.
- hinkley 10y agoI have used a technique learned early on when I was a young jerk. Instead of arguing with folks in a group, I would sit one-on-one and discuss an issue (e.g. how are we going to structure the new project). I would start with a savvy experienced team member (ok John McGinty was his name) and get a consensus between us. I used to do that and it worked very well. But then they took offices away and now every idea gets shit on before you or they can even articulate it fully. Now I have to wait until the mistakes have been made - repeatedly - and discuss alternatives in retrospectives.