2 ms·
On the subject of making code reviews a positive experience I think it has been helpful where I work to explicitly discuss code reviews. What makes a good code
by funkymike 10y ago
On the subject of making code reviews a positive experience I think it has been helpful where I work to explicitly discuss code reviews. What makes a good code review vs. a bad one. For example the idea that code review comments should be based on the substance of the code rather than style.
This stuck out to me as I tend to be very critical in code reviews, which I think made other developers uncomfortable. By talking about it though I was able to soften my approach. I was also able to make sure my language came across as reviewing the code, not the developer.