4 ms·
For the source code, I wouldn't include the compressed jQuery if possible. Speed isn't as important here as transparency and it's quite difficult to scan to tel
by thorax 16y ago
For the source code, I wouldn't include the compressed jQuery if possible. Speed isn't as important here as transparency and it's quite difficult to scan to tell whether there are any issues. I know you don't want to take up a lot of room with jQuery but it really will help increase my ability to recommend to others if all the code is easy to read.
You might also want to put comments on slightly scary things like PARTNER_APPS to be sure people don't believe Yelp are YOUR partners or something crazy like that.
Some of these things sound paranoid, but I'd like people to feel 100% comfortable using your bookmarklet.
It worked great for me and identified some things I missed somewhere. Nice work.
- mjpizz 16y agodone. I left the compressed version deployed for now, but the source code is now 100% uncompressed and commented: http://github.com/mjpizz/reclaimprivacy/blob/master/javascripts/privacyscanner.js#L6242 http://github.com/mjpizz/reclaimprivacy/blob/master/javascri... thanks for the feedback, esp about the PARTNER_APPS constant (now called BLOCKABLE_APPS for clarity)
- seasoup 16y agoInstead of copying and pasting jquery into your js, you could pull it from google's CDN, that way it would be cached for a lot of people and trustworthy. Well, trustworty-ish. :)
- sesqu 16y agoI would use a CDN for the jquery, maybe http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min... - that way, people don't have to make sure you haven't hidden the maliciousness in your version of jquery, which most people might not want to verify.