4 ms·
Including the old bit is meaningless noise there. I'd use something like "Improve email validation" or "email: send a test email as validation" or such. The b
by TheDong 10y ago
Including the old bit is meaningless noise there.
I'd use something like "Improve email validation" or "email: send a test email as validation" or such.
The body is where you can describe previous behaviour and give more details.
- Cthulhu_ 10y agoYeah that. I'd have it describe what the commit does in the subject, and both the why and how in the body: Validation of email addresses now sends a test email to the user, instead of the old regex that never worked. > Send test email to user for email address validation > > This change was done because the old regex never worked; see also {link} and {link} for more information. as an example. Ideally the header also contains a hint to the module the change was done in, etc. The linux kernel commits take this to (what comes across to me as) the highest levels.