4 ms·
While it's really nice they built this on open source compiler infrastructure, it's also too bad they took all the LLVM code and changed the license headers on
by DannyBee 10y ago
While it's really nice they built this on open source compiler infrastructure, it's also too bad they took all the LLVM code and changed the license headers on it (additionally pretending to relicense it and changing the copyright string) when that's 100% not okay:
https://github.com/Microsoft/DirectXShaderCompiler/blob/master/include/llvm/IR/Instruction.h#L5-L7 https://github.com/Microsoft/DirectXShaderCompiler/blob/mast...
I'm sure it was a script, but this needs to be fixed, stat.
Sadly, not even the first time:
https://github.com/Microsoft/WinObjC/issues/35 https://github.com/Microsoft/WinObjC/issues/35
https://news.ycombinator.com/item?id=10024377 https://news.ycombinator.com/item?id=10024377
https://news.ycombinator.com/item?id=10018208 https://news.ycombinator.com/item?id=10018208 (which devolved into a licensing discussion)
It'd be nice if folks paid a little more attention, because for releases from large companies, stuff spreads quickly, which means a year from now, there are still likely to be "mit licensed" copies of this that are still wrong :(
- pjc50 10y agoIf there's anyone reading this who's a LLVM contributor (and therefore copyright holder), can you send a DMCA notice to github over this please? https://help.github.com/articles/dmca-takedown-policy/ https://help.github.com/articles/dmca-takedown-policy/
- karim 10y agoI don't get it – why use the nuclear option when you could open an issue and ask them to look into it? This may be just an oversight.
- jpgvm 10y agoIt's almost certainly an oversight, an issue is the correct course of action here. You can always resort to DCMA if that isn't effective.
- 234dd57d2c8db 10y agoIf you don't defend your copyright you lose it. Taking legal action is appropriate. How many times does Microsoft have to make this "mistake" before it's seen as just ripping off people's code, hoping they don't notice, and then getting to make money off of said code? Microsoft is one of the largest software companies in the world, and they don't have the tooling in place to be able to use other people's code without keeping the license in tact and legal? I don't buy it.
- DannyBee 10y agoI think that's pretty unlikely. Probably try to resolve it peacefully
- chandlerc1024 10y agoAnd it's fixed! =] https://github.com/Microsoft/DirectXShaderCompiler/pull/33 https://github.com/Microsoft/DirectXShaderCompiler/pull/33 https://github.com/Microsoft/DirectXShaderCompiler/issues/30 https://github.com/Microsoft/DirectXShaderCompiler/issues/30