3 ms·

Maybe it is unfounded, but I was (am) afraid of pulling requests to open source projects. I read all the time how time-consuming is for the developers, so to se

by soneca 10y ago

Maybe it is unfounded, but I was (am) afraid of pulling requests to open source projects. I read all the time how time-consuming is for the developers, so to send poorly coded requests as a junior developer seems kind of abusive to me. Someone will "waste time" reading my request to reject it. But since you opened that door, I will take a better look and take my chances. Thanks!

samtoday 10y ago
> Someone will "waste time" reading my request to reject it. Patches don't usually get "rejected", unless it is for a political reason (we don't want that feature...). Usually the "code review" process involves the maintainer telling the patch submitter what to fix. That's my experience at least (from both sides of the table). Even experienced devs take a few feedback cycles to get the patch right in many projects.