10 ms·
I do this much more rarely than "always", and tend to continue self-reviewing or start the review a little earlier instead of explicitly leaving in a deliberate
by MaulingMonkey 10y ago
I do this much more rarely than "always", and tend to continue self-reviewing or start the review a little earlier instead of explicitly leaving in a deliberate bug, but I still act in a similar vein.
> [...] only to find out you left it there on purpose as a take-it-upon-myself approach to checking your peers' competency.
This is never my goal. I don't send a review your way in the first place unless I think you're competent. But sometimes entirely competent people are overworked, distracted, a bit too trusting... it happens. It's human. It's fine! It's happens to all of us.
I just want to not check in broken shit.
It leads to long days and late nights. If you're overworked, it's just going to make things worse. This might involve me leaning on another reviewer more for a bit. This might be more closely scrutinizing my own code for a bit. This might be me offering to help take something off your plate if I think I can fit it onto mine. This might be a little friendly ribbing that helps you bring your focus back, if you're just a bit distracted.