3 ms·

Never. I always leave a deliberate bug or two to see if the reviewer is paying attention. ;)

by payne92 10y ago

aerovistae 10y ago
It infuriates me when people do this, frankly. If it's a deliberate syntax typo that's one thing but if you leave a logic hole then you're essentially wasting other reviewers' time-- they carefully trace through the patterns to verify to themselves that the hole they think they see is in fact there, only to find out you left it there on purpose as a take-it-upon-myself approach to checking your peers' competency. You may as well come over to my desk and ask how much code I've gotten written today, to me it's just as contemptible.
- MaulingMonkey 10y ago
  I do this much more rarely than "always", and tend to continue self-reviewing or start the review a little earlier instead of explicitly leaving in a deliberate bug, but I still act in a similar vein. > [...] only to find out you left it there on purpose as a take-it-upon-myself approach to checking your peers' competency. This is never my goal. I don't send a review your way in the first place unless I think you're competent. But sometimes entirely competent people are overworked, distracted, a bit too trusting... it happens. It's human. It's fine! It's happens to all of us. I just want to not check in broken shit. It leads to long days and late nights. If you're overworked, it's just going to make things worse. This might involve me leaning on another reviewer more for a bit. This might be more closely scrutinizing my own code for a bit. This might be me offering to help take something off your plate if I think I can fit it onto mine. This might be a little friendly ribbing that helps you bring your focus back, if you're just a bit distracted.
Gigablah 10y ago
Interesting. I've heard about Van Halen specifying "no brown M&Ms in the candy bowl" in their contract rider just to see if the venue managers actually read it. Maybe you fancy yourself to be a rockstar?
AnimalMuppet 10y ago
I never do that. Sometimes I leave an accidental one or two, though...

Never. I always leave a deliberate bug or two to see if the reviewer is paying attention. ;)

by payne92 10y ago

Never. I always leave a deliberate bug or two to see if the reviewer is paying attention. ;)

It infuriates me when people do this, frankly. If it's a deliberate syntax typo that's one thing but if you leave a logic hole then you're essentially wasting other reviewers' time-- they carefully trace through the patterns to verify to themselves that the hole they think they see is in fact there, only to find out you left it there on purpose as a take-it-upon-myself approach to checking your peers' competency. You may as well come over to my desk and ask how much code I've gotten written today, to me it's just as contemptible.

MaulingMonkey 10y ago
I do this much more rarely than "always", and tend to continue self-reviewing or start the review a little earlier instead of explicitly leaving in a deliberate bug, but I still act in a similar vein. > [...] only to find out you left it there on purpose as a take-it-upon-myself approach to checking your peers' competency. This is never my goal. I don't send a review your way in the first place unless I think you're competent. But sometimes entirely competent people are overworked, distracted, a bit too trusting... it happens. It's human. It's fine! It's happens to all of us. I just want to not check in broken shit. It leads to long days and late nights. If you're overworked, it's just going to make things worse. This might involve me leaning on another reviewer more for a bit. This might be more closely scrutinizing my own code for a bit. This might be me offering to help take something off your plate if I think I can fit it onto mine. This might be a little friendly ribbing that helps you bring your focus back, if you're just a bit distracted.

Gigablah 10y ago

Interesting. I've heard about Van Halen specifying "no brown M&Ms in the candy bowl" in their contract rider just to see if the venue managers actually read it. Maybe you fancy yourself to be a rockstar?

AnimalMuppet 10y ago

I never do that. Sometimes I leave an accidental one or two, though...