4 ms·
With Servo we use https://reviewable.io/ https://reviewable.io/ on github. We don't enforce its use. If a newcomer makes a pull request, we'll just use the GH
by Manishearth 10y ago
With Servo we use https://reviewable.io/ https://reviewable.io/ on github.
We don't enforce its use. If a newcomer makes a pull request, we'll just use the GH review interface. In general simple PRs go through the GH review interface, regardless of who they're from. We break out Reviewable when a PR actually needs it (this is usually the choice of the reviewer).
This means that Servo continues to have a lower bar to contribution, without hampering maintainers on PRs that need more than GHs set of review features.
This has worked out well for us.
- StevePerkins 10y agoI've contributed to another Google project (http://vitess.io http://vitess.io) that used the the same process. So while Go is a completely different team, it's not exactly unknown within Google. Reviewable is a dramatic improvement over the stock Github tooling.