5 ms·
Changesets are a big deal for seeing progress towards code review feedback. Changesets take the typical GitHub workflow where the author force pushes to the PR
by jzelinskie 10y ago
Changesets are a big deal for seeing progress towards code review feedback.
Changesets take the typical GitHub workflow where the author force pushes to the PR to address comments and creates another "version" of that PR, with a new set of inline comments, but sharing the overarching PR comments. You can compare and contrast any set of "PR versions" in order to determine the changes applied by the author.
I desperately wish GitHub PRs worked this way.
- eridius 10y agoI use a tool https://reviewable.io/ https://reviewable.io/ which adds this functionality (and some other stuff) on top of GitHub PRs and it's invaluable.
- helper 10y ago+1 for reviewable. In addition to this feature reviewable's diff display is a lot nicer. For example it does a much better job handling whitespace only changes when a block of code gets reindented but otherwise doesn't change.
- eridius 10y agoOh yeah, collapsing whitespace-only changes is excellent. But even better is how it can detect and collapse changes introduced by rebasing the PR.
- petetnt 10y agoYou can hide whitespace-only changes in GitHub by appending ?w=1 to the end of the url too.
- eridius 10y agoBut that makes the whitespace changes literally invisible. Reviewable strikes a good balance, where it will show you whitespace changes that appear in diff hunk contexts, and also explicitly call out when it's skipping a chunk of whitespace-only changes, and you can click on that callout to ask it to show you those whitespace changes anyway.
- helper 10y agoReviewable doesn't hide whitespace changes, it shows just enough so you can tell that whitespace changed without getting in the way of reading the rest of the diff.
- closeparen 10y agoYou should try Phabricator. Diffs work this way.