3 ms·

I also maintain a great number of projects (perhaps more) and generally I give feedback on why a PR is unacceptable and leave it open until it's resolved. Somet

I also maintain a great number of projects (perhaps more) and generally I give feedback on why a PR is unacceptable and leave it open until it's resolved. Sometimes I'll close it a year or two later.

geerlingguy 10y ago
Definitely a valid approach. Usually people digging for historic non-merged requests will still find the closed requests either in Google or GitHub search, so I close them by default just to keep open PRs more focused.