4 ms·
I too think this is a bit premature, especially when I see placeholder code like this [1]. I'd also mention the redis dependency somewhere, IMO I shouldn't have
by mxvzr 10y ago
I too think this is a bit premature, especially when I see placeholder code like this [1]. I'd also mention the redis dependency somewhere, IMO I shouldn't have to go all the way here [2] to find about it.
Somewhat less important feedback:
- I want my libraries to be quiet; currently there is a lot going out to stdout. I see you already depend on debug, why not use it some more? (somewhat related: are the emojis really necessary?)
- IMO libraries shouldn't listen for uncaughtException. Libraries don't have enough context, or even the guarantee these errors belong to said library.
- require all your deps at the top; I'd like to pay that cost upfront when I start the process rather than after calling a function, potentially in the middle of doing something.
- only use backticks if you are actually doing variable interpolation.
[1] https://github.com/team-emt/razorframe/blob/master/lib/Razorframe.js#L224-L238 https://github.com/team-emt/razorframe/blob/master/lib/Razor...
[2] https://github.com/team-emt/razorframe/blob/master/lib/Razorframe.js#L8-L10 https://github.com/team-emt/razorframe/blob/master/lib/Razor...