5 ms·

The amount of times the word "updates" appears in the commits makes me feel much better at my difficulty of choosing succinct and unique commit messages.

anarazel 10y ago
Note that those aren't "change commits", but merge commits aggregating large swathes of other changes. And it's not even all merge commits, it's just the merges from Linus' "top lieutenants". But I sympathize. I often spend more time on commit messages than the actual changes...
- ajdlinux 10y ago
  Indeed - when you go and look at the individual commits, the commit messages tend to be a lot more complex :) My worst commit-message-to-code-changed ratio is a commit in the kernel with a 1307 char/175 word commit message, and a single character change...
  - koolba 10y ago
    Arguably you could frame that as "best". Link for the curious?
    - ajdlinux 10y ago
      It was a fix in PCI error handling on powerpc for a reasonably rare situation where the PCI card doesn't successfully come back up after we reset the slot or the PCI controller... https://github.com/torvalds/linux/commit/949e9b827eb4736d96df520c67d07a54c64e99b8 https://github.com/torvalds/linux/commit/949e9b827eb4736d96d...
- wolfgang42 10y ago
  Writing long commit messages (especially for internal/private projects) often gives me a slightly forlorn feeling, knowing that these words will almost certainly never be read again by another person, and possibly even I might never see them again. I persist only because when they do get read, they can be absolutely invaluable in explaining what on earth I was thinking at the time.
  - grzm 10y ago
    I persist only because when they do get read, they can be absolutely invaluable in explaining what on earth I was thinking at the time. I wish I could upvote this more than once.
  - hashhar 10y ago
    I really am thankful that you do write long commit messages. As a student starting out in OSS, I have had to track down why the particular piece of code is written like it and I go hunting down git blame and that really helps me. I also follow the practice when I can and hope that it helps future contributors or maintainers.
deleted 10y ago
[deleted]
ploxiln 10y ago
Those are summaries of summaries of branches of commits. Actual commit and merge messages all have good titles and descriptions. full list: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/?id=refs/tags/v4.9 https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.... (very "slow" at the very end of the development cycle) example merge: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=810ac7b7558d7830e72d8dbf34b851fce39e08b0 https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.... example commit: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=24d0492b7d5d321a9c5846c8c974eba9823ffaa0 https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.... I picked some of the longer ones on the first page just for contrast with your impression, many have shorter commit messages, but they all have a commit message with some explanation.

anarazel 10y ago

Note that those aren't "change commits", but merge commits aggregating large swathes of other changes. And it's not even all merge commits, it's just the merges from Linus' "top lieutenants". But I sympathize. I often spend more time on commit messages than the actual changes...

ajdlinux 10y ago
Indeed - when you go and look at the individual commits, the commit messages tend to be a lot more complex :) My worst commit-message-to-code-changed ratio is a commit in the kernel with a 1307 char/175 word commit message, and a single character change...
- koolba 10y ago
  Arguably you could frame that as "best". Link for the curious?
  - ajdlinux 10y ago
    It was a fix in PCI error handling on powerpc for a reasonably rare situation where the PCI card doesn't successfully come back up after we reset the slot or the PCI controller... https://github.com/torvalds/linux/commit/949e9b827eb4736d96df520c67d07a54c64e99b8 https://github.com/torvalds/linux/commit/949e9b827eb4736d96d...
wolfgang42 10y ago
Writing long commit messages (especially for internal/private projects) often gives me a slightly forlorn feeling, knowing that these words will almost certainly never be read again by another person, and possibly even I might never see them again. I persist only because when they do get read, they can be absolutely invaluable in explaining what on earth I was thinking at the time.
- grzm 10y ago
  I persist only because when they do get read, they can be absolutely invaluable in explaining what on earth I was thinking at the time. I wish I could upvote this more than once.
- hashhar 10y ago
  I really am thankful that you do write long commit messages. As a student starting out in OSS, I have had to track down why the particular piece of code is written like it and I go hunting down git blame and that really helps me. I also follow the practice when I can and hope that it helps future contributors or maintainers.

deleted 10y ago

[deleted]

ploxiln 10y ago

Those are summaries of summaries of branches of commits. Actual commit and merge messages all have good titles and descriptions. full list: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/?id=refs/tags/v4.9 https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.... (very "slow" at the very end of the development cycle) example merge: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=810ac7b7558d7830e72d8dbf34b851fce39e08b0 https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.... example commit: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=24d0492b7d5d321a9c5846c8c974eba9823ffaa0 https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.... I picked some of the longer ones on the first page just for contrast with your impression, many have shorter commit messages, but they all have a commit message with some explanation.