4 ms·
You can automate such a check via the github api. Resetting approval status on every commit is probably not desired behavior for most orgs.
by RSZC 10y ago
You can automate such a check via the github api. Resetting approval status on every commit is probably not desired behavior for most orgs.
- Nursie 10y agoIt is in the bank I work with right now. Makes sense to me too...
- mugsie 10y agobut the code could completely change in the next revision ... making the review pointless.
- stepanhruda 10y agoIt could but most orgs can assume good actors, and always resetting would slow the process down.
- mugsie 10y agoNot resetting would seem to make the review process moot. If you want speed, just allow everyone to merge
- stepanhruda 10y agoNo, you want a review, but can trust that people will ask for re-review if they make significant changes. If you want to completely stop people from comitting malicious code, resetting the review process is a weak safeguard.
- mugsie 10y agoeh ... if you want to audit code being committed (and for open source projects - you really do, or if you have SOX compliance regulations, or other audit processes) it is one of the best safeguards. I have seen many many bugs being introduced as part of a fix for a review comment. This is why you re-review.