3 ms·
Nice work. Does it support SFTP too? From a operational perspective FTP itself should be avoided for anything except public drop-box applications (IMHO). Also
by throwaway2016a 10y ago
Nice work.
Does it support SFTP too? From a operational perspective FTP itself should be avoided for anything except public drop-box applications (IMHO).
Also, best practice in node.js (and electron too) is to not put your node_modules folder in Git. You should add it to a '.gitignore' file.
- mitchas 10y agoYeah, I really have to spend some time cleaning everything up. The code itself is pretty messy too and needs to especially be split up into smaller files. This is the first electron or even real node projects I've worked on from scratch, so I'm still getting used to everything.
- benmcnelly 10y agoI tried doing this exact same thing and it wasn't as quick/easy as I hoped so I bailed, so first off, thank you for making it, and second, don't worry that its messy at least you got it started and that is the hard part.
- mitchas 10y agoOh god I nearly bailed as well. Some things were a huge pain to get working. That's why the code is so messy. A lot of old code left over from trial/error - and a lot of terrible loops to prevent dual FTP connections (which would error).
- mitchas 10y agoOh, and to answer your question about SFTP, no - not yet. I'm using JSFTP (https://github.com/sergi/jsftp https://github.com/sergi/jsftp), which doesn't have SFTP support yet. I wanted to get it up and running on both Mac and Windows before diving into that. I've found a few forks of JSFTP with it at least partially implemented, so that's the next thing I plan to tackle.