4 ms·
I've worked in two kinds of companies: Places where it's kind of a hassle to get code past a code review, and places where everyone's always having to put out f
by bunderbunder 10y ago
I've worked in two kinds of companies: Places where it's kind of a hassle to get code past a code review, and places where everyone's always having to put out fires all the time.
Of the two, I've had to unexpectedly work nights, weekends or even vacations at only one kind.
Guess which one I decided I'd rather work at.
- user5994461 10y agoI don't get it. The two groups are not mutually exclusive. It can be annoying to go past code reviews and yet there are fire everywhere all the time.
- lisivka 10y agoIt's very unlikely. Peer-reviews are spreading information across team, so at least two team members are understanding every area of the code, so project manager can always add more members to urgent or problematic task quickly.
- user5994461 10y agoDepends on how much people care. The code review could be half assed and not detect issues.
- mdpopescu 10y agoI have worked in one place where you couldn't get the code to pass without tests AND a code review. One of the methods I found had a cyclomatic complexity of 200+ and a single test, verifying that the result was not null. I was told "no, you can't fix that, the NY office wrote it and they'll get angry with us if we change their code and refuse to help". Things are worse than you think :)
- devdas 10y agoIME, those were the same place.