3 ms·
Well, part of the git workflow is branches. If you embraced these, you could push your full-baked code, your bug-fixes, and everything onto master, and just kee
by cookiecaper 17y ago
Well, part of the git workflow is branches. If you embraced these, you could push your full-baked code, your bug-fixes, and everything onto master, and just keep sponsored links code in a branch. You can create a "live" branch that reddit.com runs and merge in master + relevant other branches as necessary. It just seems like things would be a lot easier on both of our ends if at least the bulk of the code tracked the production reddit.com fairly closely.
Also, as CUViper suggested, I think that tagging releases and providing tarballs of these is a pretty good idea. Right now, everyone is just like, "I have commit z1z1z1z1, what do you have?", which most people can't easily memorize like a version number.
Tagging "versions" can also help with dependency changes -- for instance, the new codebase uses Cassandra instead of memcached (as I understand it); if you have the last release (currently HEAD on master) tagged as 1.2 or whatever, you can say 1.2 needs these things: x, x, x, x and our new release 1.3 needs these things: x, y, y, x. This really helps people, especially people who use "server" distributions, because many of those have only certain packages and versions for quite a while (see RHEL or Debian), like, 3-6yrs in most cases, some people go longer (some shorter, but not that many imo). master HEAD of course would be the latest and greatest without any necessary warnings, because things are expected to break on a development version. Versioning is pretty important imo.
- jedberg 17y ago> Well, part of the git workflow is branches. Internally we use a lot of branches and tagging and versioning, etc. The problem is if we published everything live, it would add a lot of overhead for us. While we do eventually publish everything, we are still a for profit company, and occasionally have to keep things secret for business reasons (like new features). Keeping track of what code is for a new features vs a fix to an old one would add a lot of overhead that we just have the time for. In the name of reduced overhead, we only publish to the public repository once we have released a feature and it is fully baked.