3 ms·

Wow, this codebase is alarmingly bad. No tests. Comments like "TODO: actually make this work" all over the place. I can see why geohot is terrified of regulator

• justinjlynn 10y ago
  Apropos, https://github.com/commaai/openpilot/issues/5 https://github.com/commaai/openpilot/issues/5 bneiluj > There is no test suite. Unit tests or E2E tests. Geohotz > Pull request please! mgraczyk > We have unit tests which have not yet been open sourced, because we haven't yet set up automatic testing on Github. [...] Wat. In what world is it acceptable to elide the test suite for your product because you don't have automatic testing setup on your repository host? Are your tests in a completely separate repo... (checks the repo history) no, you've just dumped a snapshot of your development in a git repo and pushed it to github. I really don't want to sound snide... this project has the capability to be so cool. It's just... well, if someone hands you what they say is a magic box that you can trust your life to and that box is manky and leaks strange fluids all over the shop (and it really isn't supposed to do that)... what would you think? Is that box magic? Will that box save your life? It certainly doesn't give the engineer in me great confidence in the quality of their system if this is quality of the piece they're proud enough to show everyone.
• deleted 10y ago
  [deleted]