4 ms·

Is it typical vim style to use a space after # in C files? That seems like a lot of unnecessary churn in the first file. [edit] Aaand I'm embarrassed about hav

• pyre 10y ago
  Just add ?w=1 to the Github URL to ignore whitespace.
  • mikevb 10y ago
    That's not the problem. The problem is the person making the PR projecting their own style choices instead of following the project's. They explicitly changed other contributors' code in a negative (stylistic) way.
    • tomjakubowski 10y ago
      Bram is the creator and maintainer of vim and the author of that patch. https://groups.google.com/forum/#!topic/vim_dev/QCj8lIntzCk https://groups.google.com/forum/#!topic/vim_dev/QCj8lIntzCk The space following the "#" is meant to signify that the preprocessor directive is nested one layer deep. You can see that this style is used in other files, like here: https://github.com/vim/vim/blob/master/src/gui.c#L40-L42 https://github.com/vim/vim/blob/master/src/gui.c#L40-L42 So no, I think this is Bram bringing one file's indentation style in line with the rest of the project.
      • Gracana 10y ago
        > The space following the "#" is meant to signify that the preprocessor directive is nested one layer deep. Ohhh! I really like that idea. I may adopt that, though I tend to avoid most preprocessor usage so I have little opportunity to try it out.