6 ms·
First off kudos to microsoft for open sourcing their JDBC driver. I would have figured microsoft would have used a linter to fix style issues with their code b
by cobookman 10y ago
First off kudos to microsoft for open sourcing their JDBC driver.
I would have figured microsoft would have used a linter to fix style issues with their code before Open Sourcing.
E.x:
https://github.com/Microsoft/mssql-jdbc/blob/master/src/main/java/com/microsoft/sqlserver/jdbc/SQLServerColumnEncryptionJavaKeyStoreProvider.java#L81 https://github.com/Microsoft/mssql-jdbc/blob/master/src/main...
Anyone know if microsoft is going to specify their java style guide.
- pionar 10y agoThey've also got some star imports in there (there's an issue for it). I'm sure that they'd appreciate help in cleaning it up.
- romanovcode 10y agoMicrosoft is a tech company just like many others. You can nitpick all you want but all companies have imperfect code and it is normal.
- cobookman 10y agoSure. I don't fault them. Just curious that Microsoft doesn't force a linter on devs. At google we generally force style guide compliance.
- romanovcode 10y agoMy guess is that this code is pretty old.
- louthy 10y agoIt seems to be a problem with 8 space tabs in the browser, no?