3 ms·
I've been code reviewing everything for my entire team for about 6 weeks. The idea being that we have some kind of quality control on the stuff being developed.
by chewyfruitloop 10y ago
I've been code reviewing everything for my entire team for about 6 weeks.
The idea being that we have some kind of quality control on the stuff being developed.
We're using TFS to ask for reviews, which actually works really well.
...what doesn't work is the junk I keep being sent....I bounced the same review 3 times yesterday because it didn't even compile...
When the stuff you get is decent reviews are ok....when it's junk, it's soul destroying
- izacus 10y agoI think the crux of these things is that you also kinda need the ability to fire people together with the code reviews. If you have people that send you constantly completely broken code and refuse to get better, there's just not much you can do.
- AnimalMuppet 10y agoIn our environment, you're supposed to have compiled it and run the tests before you even bother asking for a code review.
- dllthomas 10y agoThat's typically the case for us, although there's an occasional "before I finish it, what do you think of this direction?". Not a problem when rare and called out special.