3 ms·
if theyre review comments that need action then it sounds strange that it was approved? I guess for minor things that happens, most often we'd just ping the pe
by idunno246 10y ago
if theyre review comments that need action then it sounds strange that it was approved? I guess for minor things that happens, most often we'd just ping the person that made the comment even if they already gave a lgtm.
we discussed that someone could make major changes after approval which gets around the technical limitation of merging, and the answer we all agreed on was if we cant trust the author to know when to get re-approval then there was a bigger issue at play.