5 ms·
Query parameter for enabling timeline recording seems wrong. My app will remove that query parameter because it's unknown to the server
by msoad 10y ago
Query parameter for enabling timeline recording seems wrong. My app will remove that query parameter because it's unknown to the server
- faceyspacey 10y agoAgreed. There should be a function u can call in the console as a fallback similar to Perfect.start(). I bet there is, they just didn't publicize it.
- ggregoire 10y agoThe PR: https://github.com/facebook/react/pull/7549 https://github.com/facebook/react/pull/7549
- Cafey 10y agoI don't see the location.search (or toggle) used anywhere in this PR :( edit: 'isProfiling' is used but never declared so it most likely already was a toggle they used.
- evan_ 10y agoThey use window.location.href with a regex here: https://github.com/facebook/react/blob/e612826650ff68e73bff4d71db01fea8147ee1fd/src/renderers/shared/ReactDebugTool.js#L414 https://github.com/facebook/react/blob/e612826650ff68e73bff4...
- benjaminjackman 10y ago`ReactPerf.start()`
- danabramov 10y agoThere is, ?react_perf is exactly the same as ReactPerf.start().
- jannotti 10y agoDoes it remove it and redirect? If not, you're fine. I think that's why something like this is chosen. Your (server) app will rightly ignore that query parameter, but you'll probably still serve up the page. React is client-side, so it will still see it in the url. Everyone should be happy.