4 ms·
> Just a heads up comments like these don't really say anything useful. Thanks for looking through the code. I'll make the comments more meaningful on my next
by CiPHPerCoder 10y ago
> Just a heads up comments like these don't really say anything useful.
Thanks for looking through the code. I'll make the comments more meaningful on my next run through.
>
Also what's happening here? This could do with a comment for more junior devs. It's impossible to Google "function with a colon on the end of it in php"
That's a PHP 7 feature called return type declarations. If it doesn't return an instance of HiddenString, PHP will throw a TypeError.
- corobo 10y agoOh no I mean if we shrink it down to the PHP it becomes public static function decrypt(): HiddenString { } The way I worded it is implying I'm digging at you sorry. I mean the literal what does this do, I've not come across formatting things like this before
- CiPHPerCoder 10y agoYou're fine, I just didn't understand your question on the first pass. EDIT: https://github.com/paragonie/halite/compare/v3.1.1...3b95d852de5a0e7e4841870fc6efaabdd04f2eed https://github.com/paragonie/halite/compare/v3.1.1...3b95d85...
- corobo 10y agoCheers - I need to read up and play some more with PHP 7. The joys of maintaining a 5.6 world :)