3 ms·
> Ditto for if() foo vs if() { foo } At least that one can be fixed automatically by eclipse. But sure, there are some things that are difficult to automate.
by the8472 10y ago
> Ditto for if() foo vs if() { foo }
At least that one can be fixed automatically by eclipse.
But sure, there are some things that are difficult to automate. What I'm saying that one should not hassle a contributor over all those things that that can be done by machines.
- vsl 10y agoHow is that "hassle"? Somebody needs to fix it, why should it be the maintainer? In my experience, not even bothering with style is a good indicator of careless "shotgun coding" and such PRs typically have far worse issues. It's also typical that such PRs won't have real issues fixed either.
- the8472 10y ago> why should it be the maintainer? I'm saying: Why should it be either human? > In my experience, [...] That seems fairly dismissive to me. An expert in a certain area can certainly fix smaller issues with a few lines of code but only have a limited amount of time on their hands. Having to read a lengthy style guide and making sure they adhere to every single rule, especially when those rules are the opposite of their regular habits, is a non-zero hurdle to contributing. Offloading that work to a machine as far as possible lowers the burden to only those rules that cannot be applied automatically.