8 ms·
Honestly, all my internal git commit messages are "...". I intend to write (in many details) how the whole thing is designed. Give me a couple of months.
by pornin 10y ago
Honestly, all my internal git commit messages are "...".
I intend to write (in many details) how the whole thing is designed. Give me a couple of months.
- pfalcon 10y ago> Honestly, all my internal git commit messages are "...". Very insightful about how security experts write security code, thanks! All that documentation which you hope to write some time - half of it should have been in your commit messages (that's what they teach on StackOverflow, no?)
- unwind 10y agoOkay, that explains it, anyway. :) I have absolutely nothing to say when it comes to crypto, but as a C dork I found it ... quirky that the encoding/decoding functions in inner.h (https://bearssl.org/gitweb/?p=BearSSL;a=blob;f=src/inner.h;h=9edaadd1ffc799655830e87f0d77b447e58d934d;hb=HEAD https://bearssl.org/gitweb/?p=BearSSL;a=blob;f=src/inner.h;h...) seem to use e.g. uint32_t to get a 32-bit type, while assuming that char is 8 bits (rather than using uint8_t). This seems strange.
- zAy0LfpBZLC8mAC 10y agoI don't think it assumes it's 8 bits, but rather it assumes the values won't be outside the range of an 8 bit number, which should be fine, given that it's an octet-oriented protocol? Using char pointers presumably is to get correct aliasing analysis?