3 ms·

Well, I did skim a little bit through Eve's source code, specifically the files in https://github.com/witheve/Eve/tree/master/src https://github.com/witheve/Eve

Well, I did skim a little bit through Eve's source code, specifically the files in https://github.com/witheve/Eve/tree/master/src https://github.com/witheve/Eve/tree/master/src and subs, and the first thing that stroke me was: it's not literate. As a matter of fact, it doesn't have more comments than an average code base, maybe even less. Why? Where is the prose? What makes programs supposed to be written in Eve different from Eve itself?

ibdknox 10y ago
Trying to do literate programming in traditional languages is pretty crappy [1]. Some heroic effort ended up having to go into this release as well so things aren't as commented as we wanted, but that will improve. There are a few files that are pretty good though [2]. Our Eve source on the other hand is wonderfully literate and it's been a really great experience. Here's the code that makes the inspector work [3]. [1]:http://programming.witheve.com/deepdives/literate.html http://programming.witheve.com/deepdives/literate.html [2]: https://github.com/witheve/Eve/blob/master/src/runtime/join.ts#L683 https://github.com/witheve/Eve/blob/master/src/runtime/join.... [3]: http://play.witheve.com/#/examples/editor.eve http://play.witheve.com/#/examples/editor.eve
- brianwawok 10y ago
  I only looked at 2.. but honestly, that looked like the kind of code I got delivered from offshore teams. 3 lines of comments saying what a for loop will do, then 1 line to do the for loop. I would -1 most of that on a code review, and ask for comments that just describe what the code is doing to be removed.
  - zubairq 10y ago
    I can show you plenty of crappy code delivered from local teams too, especially myself!
ThePhysicist 10y ago
Good software can be written with bad code. Python is just "ugly" C underneath, containing for example a 1500 line switch statement, but this does not in any way change the fact that it's a great piece of software.

ibdknox 10y ago

Trying to do literate programming in traditional languages is pretty crappy [1]. Some heroic effort ended up having to go into this release as well so things aren't as commented as we wanted, but that will improve. There are a few files that are pretty good though [2]. Our Eve source on the other hand is wonderfully literate and it's been a really great experience. Here's the code that makes the inspector work [3]. [1]:http://programming.witheve.com/deepdives/literate.html http://programming.witheve.com/deepdives/literate.html [2]: https://github.com/witheve/Eve/blob/master/src/runtime/join.ts#L683 https://github.com/witheve/Eve/blob/master/src/runtime/join.... [3]: http://play.witheve.com/#/examples/editor.eve http://play.witheve.com/#/examples/editor.eve

brianwawok 10y ago
I only looked at 2.. but honestly, that looked like the kind of code I got delivered from offshore teams. 3 lines of comments saying what a for loop will do, then 1 line to do the for loop. I would -1 most of that on a code review, and ask for comments that just describe what the code is doing to be removed.
- zubairq 10y ago
  I can show you plenty of crappy code delivered from local teams too, especially myself!

ThePhysicist 10y ago

Good software can be written with bad code. Python is just "ugly" C underneath, containing for example a 1500 line switch statement, but this does not in any way change the fact that it's a great piece of software.