4 ms·
> and dies on the JSON decode That's the part I don't get. Once the code dies it's done. What exactly can you do now, if no code is even running?
by ars 10y ago
> and dies on the JSON decode
That's the part I don't get. Once the code dies it's done. What exactly can you do now, if no code is even running?
- SomeStupidPoint 10y agoThe steps are the following: 1. Parse user. 2. Parse password. 3. Create session object from user and password. 4. Parse JSON. (Crashes here.) 5. Update session and do some other security stuff. The problem is that they're creating a persistent session object ahead of when the JSON parameters are being decoded, which leaves a (partially initialized, persisting-outside-of-function) session object without having gone through the full authentication flow. The problem is that they're creating permanent objects ahead of a full validation on the data necessary to actually properly initialize the object. (I think the OP may have been a little vague because that's probably specific enough to identify the vuln with a scanner and a hunch.)
- umbrai_nation 10y agoWait, so it creates a privileged session before verifying the password? That's your problem right there. A crash in the JSON processor (or anywhere else) is a minor blip compared to this godzilla bug of granting access before it's been earned.
- mathw 10y agoSpot on! But if the JSON parser couldn't crash on malformed input, that kind of whopping mistake would be a lot harder to exploit.
- mort96 10y agoRemember, it's PHP. Code will be running again on the next request. Only the process (or thread or whatever) handling the request with the invalid JSON crashes, and it only crashes after producing a persistent session; the next request, a different process/thread/whatever will run code, but the session from the previous request still exists.
- KayEss 10y agoI still don't get it. The browser gets the session cookie even though the request processing crashed? Or does another request manage to pick up the session that was dropped from the crashed request? I don't do PHP. It just sounds incredible to me that so little isolation seems to exist.