3 ms·
In addition to the other good recommendations: be responsive. When you get requests to make changes or questions about what you've done, don't just disappear. P
by tedyoung 10y ago
In addition to the other good recommendations: be responsive. When you get requests to make changes or questions about what you've done, don't just disappear. PRs have a short shelf-life, and if you're not going to respond in a timely manner (even if it's "hmm, I need to think about this"), then hold off on submitting your PR until you have time to follow through on the review feedback.