3 ms·
...I find myself telling this anecodote more or less at weekly intervals, but: Where I work all code is reviewed. Like, it has to be reviewed before it gets ch
by david-given 10y ago
...I find myself telling this anecodote more or less at weekly intervals, but:
Where I work all code is reviewed. Like, it has to be reviewed before it gets checked in. Everyone does reviews, everyone has their code reviewed.
One of the people I work with has an amazing talent which is that you go through a review with them, and at the far end you feel enthusiastic and pumped and really keen to throw all your code away and rewrite it from scratch, because they've just pointed out all the incredibly stupid stuff they've done wrong, but they've done it in such a way that you feel really good about all the stuff you've just learned.
Meanwhile I've gone through much less severe reviews from other people that have left me depressed and completely unenthusiastic, even though they thought my code was fine.
Positive, supportive, constructive, and critical: it's totally possible (and I need to learn how to do it).