6 ms·
> too much 'public' elements in a class (justified by the programmer thinking: "just in case" someone needs to access them in the future) I've seen someone 15
by loup-vaillant 10y ago
> too much 'public' elements in a class (justified by the programmer thinking: "just in case" someone needs to access them in the future)
I've seen someone 15 years my senior make that mistake; then take issue when I removed the unnecessary code. He eventually had me fired.
The "just in case" thinking is often used to justify some otherwise useless OO looking pattern, which once implemented is difficult to excise, because the alternatives tend to look less "OO" and less "pattern-y".
- Can_Not 10y ago> I've seen someone 15 years my senior make that mistake; then take issue when I removed the unnecessary code. He eventually had me fired. You deleting his extra "thinking ahead" code was subversive behavior and you deserved to be fired. You might technically have been right that his coding preferences were suboptimal, but it's not your place to (from his perspective) randomly delete good code. As far as I can tell, you blindly followed a clean code "quick rule of thumb" and butchered the bigger picture causing actual damages to productivity in addition to waisting your developer own time.
- loup-vaillant 10y agoIt's more complicated. First, I only touched code I was meant to use or update. Second, the guy refused to review my code until much too late. Third, he had me suffer his daily sarcasms practically from day one, sometimes in front of the customer. The real reason he had me fired was because I treatead him like a peer (as I was told we were), while in fact he wanted to be the boss.