4 ms·
Here is some of my comments: Don't hardcode error levels like you do in your bootstrap file (wireframe.php) ini_set('display_errors', 1); I am not a fan
by EJTH 10y ago
Here is some of my comments:
Don't hardcode error levels like you do in your bootstrap file (wireframe.php)
ini_set('display_errors', 1);
I am not a fan of setting title from some HTML comments, I can't really understand why you would do this when writing a PHP framework, as you wouldn't be able to make dynamic titles.
While nothing wrong with this code as such:
if (file_exists($file)) {
return true;
} else {
return false;
}
It is unnecessary to explicitly return true or false,
return file_exists($file);
Would have done the same...
Lastly I really think that you should consider using PSR-4 style autoloading for your internal classes, I see no point in not doing it.
- tbirrell 10y agoThanks for the feedback! I am unfamiliar with PSR-4, I'll have to give it a look.