4 ms·
> This seems like a _terrible_ mistake. I can at least confirm with certainty that it sometimes is a terrible mistake. I port things. One approach I sometime
by MaulingMonkey 10y ago
> This seems like a _terrible_ mistake.
I can at least confirm with certainty that it sometimes is a terrible mistake.
I port things. One approach I sometimes use is to stub in noop implementations of platform specific things. I generally use #pragmas or the like to generate a warning to come back to (which I can always later crank up to an error to ensure I've gone back and implemented everything.) It's common that the original authors were also "kind enough" to leave some noop implementations of their own - although usually not with the helpful #pragmas.
End result: Thousands of failing unit tests, most of which were passing for more than a year. Some are innocuous as minor string formatting changes caused by minor libc differences - but even that can be concerning if you want consistent, reliable results that don't vary by platform and threaten to cause platform specific edge cases.
I've never seen a codebase where even 10% of the failures are that innocuous.