3 ms·

Why is atoa() being used on arguments? You can pass an arguments object to apply(). It even avoids deoptimization (at least on V8), IIRC. (No explanation at htt

• wanda 10y ago
  This is indeed true for V8 IIRC, but even if it weren't, both arguments.length and arguments[x] are safe to use without stopping optimisation, so even a very cautious JavaScript dev can effectively clone the arguments object in a roundabout sort of way and pass it to apply, like so: // given a context and function 'func' var args = []; for(var i = 0; i < arguments.length; i++){ args[i] = arguments[i]; } func.apply(context, args); Source: https://github.com/petkaantonov/bluebird/wiki/Optimization-killers https://github.com/petkaantonov/bluebird/wiki/Optimization-k...
  • minitech 10y ago
    Right, but passing it to atoa() (unless it’s a macro? I didn’t check) seems redundant and deoptimizes.
    • wanda 10y ago
      Oh yes, you're absolutely right there. Even if it were okay, it's an absurd dependency.
• rhinoceraptor 10y ago
  If you're using ES2015, you can do let argArray = (...args) => doStuffWithArgArray(...args)