3 ms·
I find this interesting. I have a few nitpicks for everyone's consideration. >* The source code is more than 100 MB. Excluding images, example usage, and gene
by epochwolf 17y ago
I find this interesting. I have a few nitpicks for everyone's consideration.
>* The source code is more than 100 MB.
Excluding images, example usage, and generated documentation, sure.
>* Your code tries to install into /opt or /usr/local [ +10 points of FAIL ]
Installing to /usr/local is the accepted default for linux. Plus, I actually use the package manager on my system. I want compiled software to install to /opt or /usr/local so I can find it later and remove it if necessary.
Now trying to install to /opt on windows is just stupid.
>* Your code does not have per-file licensing [ +10 points of FAIL ]
This is pedantic. If the entire codebase is under the same license which is given as LICENSE in the program's folder you're good. (You should make it clear in README that LICENSE does apply to the entire project.) If not, any inconsistent licensing should be explicitly defined either in a visible top level document next to LICENSE which lists each exception clearly (e.g. stuff in multiverse/ is proprietary, see multiverse/<project>/LICENSE for details) or at the top of each file that doesn't match the license in LICENSE.
- ominous_prime 17y ago>* Your code tries to install into /opt or /usr/local [ +10 points of FAIL ] I think this one bothered me the most. `/usr/local` is the correct default location for user installed software, per the "Filesystem Hierarchy Standard". If the software's static file must be contained in a `./<package>`or `./<provider>` directory (vs bin, lib, share...), it should probably go in `/opt`.
- epochwolf 17y agoAh... I see. Nginx likes to install itself to /usr/local/nginx which isn't correct per FHS. It should install to /opt/nginx.
- ominous_prime 17y agoYeah, but since /opt isn't always created by default on all systems, I don't think it's that big a deal. You can almost always count on /usr/local being there. As long as they don't go and dump stuff in /{bin,lib} or /usr/{bin,lib}.