4 ms·

tl;dr: my wish is a code review convention for git-notes and a friendly UI on top. If only Git would allow storing reviews and issues in the repo proper. Somet

by exDM69 10y ago

tl;dr: my wish is a code review convention for git-notes and a friendly UI on top. If only Git would allow storing reviews and issues in the repo proper. Something like Git notes with conventions to refer to files/lines in a file/different revisions etc. Something similar to Fossil. This would solve half of the problem. The other half would be the UI layer. Now the reviews live in a database, outside of the repo, and can't be downloaded locally for offline work. This would allow doing code reviews and managing issues e.g. while commuting in a train. And everything would be pretty fast compared to waiting for a web page to load for every file you want to review and connecting to a server for every comment you write.

erikb 10y ago
Why does email not solve your problem? It allows offline work, you can store the reviews on your computer, you can even commit it to git if you want. Also check out emacs' org-mode for an alternative approach. And last but not least, does it just sound like you value the review higher than the code? Why should it be more than a text file like any other? Meaning is something we add to the text. A tool with a specific goal like git shouldn't enhance a meaning to an object type.
- exDM69 10y ago
  The review comments still live outside of the repo, in an unformatted ad-hoc format that's not easy to write a nice UI for. Ideally, I should be able to add review comments in a graphical diff viewer or web front-end and every dev should be able to choose the tools they prefer. Email workflow would solve the connectivity issues, but the reviews, issues etc are not stored for posterity along with the code. Reviews don't need to be much more than text, but they need some metadata to refer to files/revisions/lines. Basically this could be solved with some conventions on top of text files that machines could understand. What I'm after is something like Fossil, where all the project management can be done offline and in a structured way.
  - erikb 10y ago
    Fossil looks quite interesting. Thanks for the reference. https://www.fossil-scm.org/index.html/doc/trunk/www/concepts.wiki https://www.fossil-scm.org/index.html/doc/trunk/www/concepts...
ktt 10y ago
Something like this https://github.com/google/git-appraise https://github.com/google/git-appraise ?
- exDM69 10y ago
  Yes, something like that. I've seen it before and it sparked my interest. Not sure about using json, though. Now this project is just the first step, now it needs a code review tool (UI) on top that's good enough to match Gerrit, GitHub, etc.
preenly 10y ago
Would an offline code review application work? something which synced the comments on internet access resuming? I am planning something similar with https://about.preen.ly https://about.preen.ly

by exDM69 10y ago

erikb 10y ago

Why does email not solve your problem? It allows offline work, you can store the reviews on your computer, you can even commit it to git if you want. Also check out emacs' org-mode for an alternative approach. And last but not least, does it just sound like you value the review higher than the code? Why should it be more than a text file like any other? Meaning is something we add to the text. A tool with a specific goal like git shouldn't enhance a meaning to an object type.

exDM69 10y ago
The review comments still live outside of the repo, in an unformatted ad-hoc format that's not easy to write a nice UI for. Ideally, I should be able to add review comments in a graphical diff viewer or web front-end and every dev should be able to choose the tools they prefer. Email workflow would solve the connectivity issues, but the reviews, issues etc are not stored for posterity along with the code. Reviews don't need to be much more than text, but they need some metadata to refer to files/revisions/lines. Basically this could be solved with some conventions on top of text files that machines could understand. What I'm after is something like Fossil, where all the project management can be done offline and in a structured way.
- erikb 10y ago
  Fossil looks quite interesting. Thanks for the reference. https://www.fossil-scm.org/index.html/doc/trunk/www/concepts.wiki https://www.fossil-scm.org/index.html/doc/trunk/www/concepts...

ktt 10y ago

Something like this https://github.com/google/git-appraise https://github.com/google/git-appraise ?

exDM69 10y ago
Yes, something like that. I've seen it before and it sparked my interest. Not sure about using json, though. Now this project is just the first step, now it needs a code review tool (UI) on top that's good enough to match Gerrit, GitHub, etc.

preenly 10y ago

Would an offline code review application work? something which synced the comments on internet access resuming? I am planning something similar with https://about.preen.ly https://about.preen.ly