3 ms·
Perhaps I don't understand the Gerrit workflow, but last time I read about Gerrit it looked like it had a philosophy of "one commit, one review". That sounds l
by adrianratnapala 10y ago
Perhaps I don't understand the Gerrit workflow, but last time I read about Gerrit it looked like it had a philosophy of "one commit, one review".
That sounds like an anethema for the kernel, where they want to review a series of tidied up commits, one per email.
- kiallmacinnes 10y agoGerrit does have "one commit, one review", but - that's not a bad thing. If a change is well written and structured, merging the first in the chain without the second+ is both harmless and is progress towards the end goal. There's also patch chains in Gerrit, so you can see the X commits that make up the full change, and the second+ cannot be merged before the first.
- xjia 10y agoDoes the topic branch feature help? I personally always use it.