4 ms·

> so I don't have to keep going back to my own terminal after my PR is approved. Why would you have to go back to your terminal after the PR is approved? In ei

• bnchrch 10y ago
  This would be true if we had one person responsible for the merge! We have a small team of developers and proper rebase and merge is the responsibility of the PR author after it has passed code review + testing. In short: all devs are admins. edit: anyway this would still be a huge help to the sole admin if we had one.
• ni-hil 10y ago
  Because sometimes the admin just tells you "ok, rebase then I will merge" and don't bother doing the rebase himself...
  • dsp1234 10y ago
    If there is a conflict during the rebase, the developer working on the new feature will have more information on how to fix it. So it makes sense for the developer to rebase before submitting.
• lmm 10y ago
  Why would you have a separate "admin" do that? It doesn't require a separate skillset; the developer is in the best position to shepherd their feature into production, and by giving them ownership of their feature they can stick closer to solving the actual problem, and likely get more satisfaction from their work as well.