4 ms·

Wouldn't it have made sense to revert the first subpar commit, pulled aside the contributors and explained to them what is acceptable? Disowning the project se

by ckdarby 10y ago

Wouldn't it have made sense to revert the first subpar commit, pulled aside the contributors and explained to them what is acceptable? Disowning the project seems like a lose/lose situation.

daurnimator 10y ago
It was a project that I didn't give a lot of love, and hence just gave them commit rights. It was about a year later before I looked again, by which time they had done far too much work on top of their non-cross-platform bits for me to revert. I still didn't use the project myself; and didn't care enough to fix it, so I just removed myself.
- justinclift 10y ago
  Yeah, that's one of the dangers. Did you start a conversation with them about it, or just move on silently? I'm trying to think of a good way to start such a conversation... but it sounds tricky. Probably would depend on the personality of the person. ;)
josephg 10y ago
I'm not the parent, but I've been burned in the same way. In an ideal world, yes - that would be the right way to handle the situation. In a company you'd want to do that, and probably give the programmer a mentor who can do code reviews and whatnot. Unfortunately thats: - Thats a complicated conversation to have at the best of times. With volunteers over the internet its much harder to organise 1-on-1s. - A huge time sink. Usually I could make the changes themselves in less time than it would take me to explain the changes to a junior developer. Its especially hard to justify for projects I have in maintenance mode, where I don't want to spend time working on project features at all. Long term hopefully the time investment will pay off, but they'll probably disappear long before then. - Honestly, its also not that much fun. I contribute to opensource projects because I like making things. Managing people doesn't rub that itch. I'm not saying I have a better solution. But faced with a stream of mediocre PRs from an enthusiastic new contributor that you don't have time to review, what do you do? Abandoning the project to the new contributor sounds pretty reasonable to me.
emodendroket 10y ago
Why not just let them fork the project if they want to take it in a different direction?

by ckdarby 10y ago

Wouldn't it have made sense to revert the first subpar commit, pulled aside the contributors and explained to them what is acceptable? Disowning the project seems like a lose/lose situation.

daurnimator 10y ago

It was a project that I didn't give a lot of love, and hence just gave them commit rights. It was about a year later before I looked again, by which time they had done far too much work on top of their non-cross-platform bits for me to revert. I still didn't use the project myself; and didn't care enough to fix it, so I just removed myself.

justinclift 10y ago
Yeah, that's one of the dangers. Did you start a conversation with them about it, or just move on silently? I'm trying to think of a good way to start such a conversation... but it sounds tricky. Probably would depend on the personality of the person. ;)

josephg 10y ago

I'm not the parent, but I've been burned in the same way. In an ideal world, yes - that would be the right way to handle the situation. In a company you'd want to do that, and probably give the programmer a mentor who can do code reviews and whatnot. Unfortunately thats: - Thats a complicated conversation to have at the best of times. With volunteers over the internet its much harder to organise 1-on-1s. - A huge time sink. Usually I could make the changes themselves in less time than it would take me to explain the changes to a junior developer. Its especially hard to justify for projects I have in maintenance mode, where I don't want to spend time working on project features at all. Long term hopefully the time investment will pay off, but they'll probably disappear long before then. - Honestly, its also not that much fun. I contribute to opensource projects because I like making things. Managing people doesn't rub that itch. I'm not saying I have a better solution. But faced with a stream of mediocre PRs from an enthusiastic new contributor that you don't have time to review, what do you do? Abandoning the project to the new contributor sounds pretty reasonable to me.

emodendroket 10y ago

Why not just let them fork the project if they want to take it in a different direction?