4 ms·
> Sometimes a gritty algorithm really does make the most sense if it's laid out as a 40 line function in one place rather than spread across 5 different classes
by wyldfire 10y ago
> Sometimes a gritty algorithm really does make the most sense if it's laid out as a 40 line function in one place rather than spread across 5 different classes so each part is independently swappable and testable.
I agree with you, but it feels a little like a false dichotomy. You can pretty easily decompose a long function into multiple smaller ones, within the same file. ~40 lines is close to the breaking point IMO. If it grows much beyond that, you can probably see groups of 10+ lines of code that have some sane subset of inputs/outputs. Toss those lines in another function, give it a name, make sure it's not exported outside of this file. If the 40+ line function gets reduced to a 10-20 line one with a few more stack frames, it is probably worth it.
- peterloveslucy 10y ago40 lines is excessive, I prefer simple methods that take care of the if's and link them together serially. AFAICS this is the way the brain works. /** * get the leaf node as a string * @param obj the json object to operate on * @param path the dot path to use * @return the leaf node if present <b>and textual</b>, otherwise null */ public static String leafString(ObjectNode obj, String path) { JsonNode leaf = leaf(obj, path); return leaf != null && leaf.isTextual() ? leaf.asText() : null; }
- halostatue 10y agoThat mostly depends on where the algorithm is used. If it’s in a tight loop, those extra stack frames are deadly and completely not worth it.
- jblow 10y agoWhat size of codebase are you talking about? If it's 100,000 lines of code, and you break stuff every 40 lines, you have now introduced 2500 procedures many of which don't really need to exist. But because they do exist, anyone who comes along now has to understand this complex but invisible webbing that ties the procedures together -- who calls who, when and under what conditions does this procedure make sense, etc. It introduces a HUGE amount of extra complexity into the job of understanding the program. (Also you'll find the program takes much longer to compile, link, etc, harming workflow). I regularly have procedures that are many hundreds of lines, sometimes thousands of lines (The Witness has a procedure in it that is about 8000 lines). And I get really a lot done, relatively speaking. So I would encourage folks out there to question this 40-line idea. See also what John Carmack has to say about this: http://number-none.com/blow/blog/programming/2014/09/26/carmack-on-inlined-code.html http://number-none.com/blow/blog/programming/2014/09/26/carm...
- chimprich 10y agoCarmack in that link isn't exactly giving unqualified support to your position. The first sentence links to where he's now a big fan of functional programming and supports programming using combinations of pure functions.
- jblow 10y agoObviously, he's a different person and has a different opinion. My experience has been that people on HN tend to interpret that part of the posting a little more extrapolatingly than I do. I think he is saying something pretty obvious, which is that when you can structure things in terms of pure functions, you don't have to worry about the side-effects that are one of the main issues you need to contend with when factoring things apart. This is different from being a "fan of functional programming", i.e. believing you should use current functional programming languages to build your projects, or whatever.
- pvg 10y agoI'm curious about the 8000 line procedure and what made it the best approach in your case. Also, how do you navigate inside it?
- jblow 10y agoIt's the procedure that constructs most of the puzzle panels in the game. Usually I just search for the name of the puzzle I want to edit (which is also how you'd do it if it were a ton of different procedures).
- pvg 10y agoHah, that's cheating! I'm not trying to defend an 'N-lines' rule which seems too obviously silly to even argue about but people do often break out chunks of code into procedures to give them logical, navigable names. You have names inside your big procedure.
- bdavisx 10y ago