3 ms·
Batched review and pending state have both been a long time coming. Most of the times when I do a review it's not a single comment and right now the workflow i
by avitzurel 10y ago
Batched review and pending state have both been a long time coming.
Most of the times when I do a review it's not a single comment and right now the workflow is to let the team know on Slack that I am reviewing this.
From the Gif it's not 100% clear what the pending state does but I would want something like blocking the PR until every team member that started reviewing will "release" the PR. I also see the negative side of this of course but I think the positive outweighs the negatives.
- mwarkentin 10y agoYou can block merges until there's an "approved" code review in the Protected Branches setting. I don't think it has anything like "everyone who reviewed must approve" though.