3 ms·
Phabricator is a really solid GitHub alternative. Some of the largest open source projects are using it and lots of companies. I believe that the GitHub pull r
by lima 10y ago
Phabricator is a really solid GitHub alternative. Some of the largest open source projects are using it and lots of companies.
I believe that the GitHub pull request workflow and issue tracker does not scale to large projects and very much prefer Gerrit/Phabricator. Phabricator was created at Facebook for a large development team (mobile apps) and it shows. They have solutions for issues which only appear at scale (code ownership in monorepos, for example - the owners/herald mechanism). It's also very performant, has almost no dependencies and is extremely easy to deploy.
GitLab is a great GitHub alternative, but it's also copying
its flaws.
Great writeup here: (not mine)
http://cramer.io/2014/05/03/on-pull-requests http://cramer.io/2014/05/03/on-pull-requests
HN discussion: https://news.ycombinator.com/item?id=7697132 https://news.ycombinator.com/item?id=7697132
Good quote from that discussion:
> As far as code reviews go, this is pretty spot on. I was part of a a startup that was using GitHub pull requests for code reviews. As the team grew, it became more and more intractable, although not simply because of notifications. Side-by-side diffs and checkpointed diffs (so that you can see what changed since the last round of review and whether/how your comments were addressed) are handled very poorly by GitHub. We ultimately switched to Phabricator, and while there was a little friction as folks got acquainted with the new tool, it made code reviews a much more pleasant process.
Recently, I had to go through a full code review back on GH pull requests, and it felt like pulling teeth in comparison. They're fine for interacting with contributors to an open source project, but compared to working with a tool like Phabricator that's built for a code reviewer's workflow (and for teams of engineers working together on a project), they just don't hold a candle, in my opinion.
- jobvandervoort 10y agoWe have many requests to improve our code review and make it more like Phabricator and Gerrit. We want to strike a balance between light-weight and powerful, but fully intend to give you all the power of a Phabricator or Gerrit in GitLab. We're working on several [0] initiatives towards this goal. If you are interested in seeing these improvements in GitLab, please let us know what is important and what we're not seeing! [0]: https://gitlab.com/gitlab-org/gitlab-ce/issues/19049 https://gitlab.com/gitlab-org/gitlab-ce/issues/19049
- lima 10y agoI'm not a GitHub user myself, only have experience with GitHub. The article I linked outlined it very well. Essentially, what I need is code ownership (like Phabricator's "Owner" feature or Chromium's OWNER file: https://www.chromium.org/developers/owners-files https://www.chromium.org/developers/owners-files) and essentially what's outlined in the article I linked (diffs instead of heavyweight merge requests).
- sytse 10y agoInteresting, I created https://gitlab.com/gitlab-org/gitlab-ce/issues/22141 https://gitlab.com/gitlab-org/gitlab-ce/issues/22141 to discuss.
- sytse 10y agoPhabricator has many great features and we try to learn from it to improve GitLab. Your quote touches on two things we recently improved: 1. In GitLab 8.11 https://about.gitlab.com/2016/08/22/gitlab-8-11-released/ https://about.gitlab.com/2016/08/22/gitlab-8-11-released/ we added the ability to resolve comments, solving "whether/how your comments were addressed" 2. In the upcoming GitLab 8.12 we've added the ability to show merge request version https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6127 https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6127, solving "what changed since the last round of review" Please let us know if there are any other specific things we can solve.