4 ms·
I recently heard a rule of thumb: "accept interfaces, return structs". I haven't put it into practice, but it seems like this should give callers enough flexib
by skybrian 10y ago
I recently heard a rule of thumb: "accept interfaces, return structs".
I haven't put it into practice, but it seems like this should give callers enough flexibility to pass in whatever they like.
- zalmoxes 10y agoThat really depends on what you're tying to do. Say you have a Datastore interface, which has some methods like "Create", "Update", "Delete", and a MySQL + an inmem implementation. You can have `datastore.New() Datastore`, which returns one of the implementations, or you can have `datastore.NewMySQLStore, datastore.NewInMemStore()`. Now you need a different method for each implementation. Also be careful with returning concrete type, you can run into this issue: https://play.golang.org/p/WHAW1X6elS https://play.golang.org/p/WHAW1X6elS
- patates 10y agoWow, that seems like a big issue. Is this accepted as a bug and being worked on or yet another feature?
- weberc2 10y agoIt's not a bug. Interfaces are reference types. In this case, the interface is implemented by a pointer type. The interface can be thought of as a pointer to a nil pointer, but the "interface pointer" itself is not nil. This is a tricky concept until you learn that interfaces are reference types. Here's a simplified version of the previous example that illustrates this concept: https://play.golang.org/p/pODBgaHXq5 https://play.golang.org/p/pODBgaHXq5
- lloeki 10y agoIndeed I remember someone laying out some Go good practices (Rob Pike? Andrew Gerrand? damn can't recall) and "accept interfaces, return types" was definitely one of them. Again, a rule of thumb that works very well in most (not all) cases, and, conversely, a code smell.
- weberc2 10y agoHmm, I'm not sure that rule of thumb is very good. I think a better one would be "accept interfaces when you want polymorphism". Often I have a very high degree of confidence that your caller will never want to pass a different implementation, and creating the extra interface for an improbably hypothetical situation just isn't worth my time? I'm not making any statements here, just wondering out loud.