4 ms·

This is cool! Thanks for sharing. I like how you can open the comments inline. One thing I think that might be cool to add would collapse button that shows (bot

This is cool! Thanks for sharing. I like how you can open the comments inline. One thing I think that might be cool to add would collapse button that shows (bottom right the screen maybe?) when you open inline comments. It would be nice to collapse the comments without having to scroll all the way back up.

sras-me 10y ago
> It would be nice to collapse the comments without having to scroll all the way back up. Was done like that initially. But when user collapses the inline display, it felt that the user is left at a random location, and had to scan the items to find where they left off. So I removed the link at the bottom to collapse the inline display, forcing them to use the top link. When the user collapses using the top link, the scroll position is not 'jumped', and hence the experience felt better.
- MrAwesomeSauce 10y ago
  Fair point, I can see how that can feel like you're left at a random location. One other thing I noticed is that stories don't seem to load on my iPhone, but works fine on browser. Not sure why though.
  - sras-me 10y ago
    >One other thing I noticed is that stories don't seem to load on my iPhone, but works fine on browser. I am not sure (I don't have an iPhone around to test this), but it might be because there are no story sources configured in your Phone. The link I provided, https://sras.me/reform/#/setconfig;reddit=programming,science,askscience;hackernews=topstories,beststories,askstories,showstories https://sras.me/reform/#/setconfig;reddit=programming,scienc... was a config url, that included a bunch of story sources to use (subreddit and HN pages). This config is stored in the local storage. So you don't have to use the config url next time you use the app. You can also add subreddit and hackernews pages using the settings page. Can you please try it and let me if this is the case? If it is not, can you please check if the log is showing any network activity (there is a log at the bottom where it shows active requests)
    - MrAwesomeSauce 10y ago
      Okay it's not the iPhone, it's just Safari for some reason. Tried on Chrome and everything loads perfectly fine (I like the experience on mobile). I can add stories and everything no problem. On Safari I don't see any requests and clicking add story or Reddit does nothing :(
      - sras-me 10y ago
        I just tried it on Safari in my Macbook. It seems to work fine (Version 9.0.3 (11601.4.4)). Anyway, it is alright. Thanks for all your feedback. I found a small issue with your app. Please take a look at [1]. When the thread is too deep, the container becomes so narrow that the text becomes almost vertical. [1] https://angular2-hn.firebaseapp.com/item/12455034 https://angular2-hn.firebaseapp.com/item/12455034
        MrAwesomeSauce 10y ago
        Okay weird, yeah not sure why it's happening for me. And thanks so much for spotting that, will fix that up.

sras-me 10y ago

> It would be nice to collapse the comments without having to scroll all the way back up. Was done like that initially. But when user collapses the inline display, it felt that the user is left at a random location, and had to scan the items to find where they left off. So I removed the link at the bottom to collapse the inline display, forcing them to use the top link. When the user collapses using the top link, the scroll position is not 'jumped', and hence the experience felt better.

MrAwesomeSauce 10y ago
Fair point, I can see how that can feel like you're left at a random location. One other thing I noticed is that stories don't seem to load on my iPhone, but works fine on browser. Not sure why though.
- sras-me 10y ago
  >One other thing I noticed is that stories don't seem to load on my iPhone, but works fine on browser. I am not sure (I don't have an iPhone around to test this), but it might be because there are no story sources configured in your Phone. The link I provided, https://sras.me/reform/#/setconfig;reddit=programming,science,askscience;hackernews=topstories,beststories,askstories,showstories https://sras.me/reform/#/setconfig;reddit=programming,scienc... was a config url, that included a bunch of story sources to use (subreddit and HN pages). This config is stored in the local storage. So you don't have to use the config url next time you use the app. You can also add subreddit and hackernews pages using the settings page. Can you please try it and let me if this is the case? If it is not, can you please check if the log is showing any network activity (there is a log at the bottom where it shows active requests)
  - MrAwesomeSauce 10y ago
    Okay it's not the iPhone, it's just Safari for some reason. Tried on Chrome and everything loads perfectly fine (I like the experience on mobile). I can add stories and everything no problem. On Safari I don't see any requests and clicking add story or Reddit does nothing :(
    - sras-me 10y ago
      I just tried it on Safari in my Macbook. It seems to work fine (Version 9.0.3 (11601.4.4)). Anyway, it is alright. Thanks for all your feedback. I found a small issue with your app. Please take a look at [1]. When the thread is too deep, the container becomes so narrow that the text becomes almost vertical. [1] https://angular2-hn.firebaseapp.com/item/12455034 https://angular2-hn.firebaseapp.com/item/12455034
      - MrAwesomeSauce 10y ago
        Okay weird, yeah not sure why it's happening for me. And thanks so much for spotting that, will fix that up.